Add LVideoOverlay #683
Open
Add LVideoOverlay #683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 21, 2021 17:58
|
@mandryllo thanks again for these contributions! I know that there are currently no tests for the LImageOverlay component that you are extending here, but it would be great if you could add some tests both here and in #684 for the new code and components at least. If you had time to backfill the tests for LImageOverlay as well then that would be fantastic, even if it only covered the url prop that's been moved around. |
|
@mikeu I will add them, probably sometime next week 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
LVideoOverlaycomponent (link)Depends on #685